Skip to content

fix: discard auth migration telemetry silently in broker mode #4299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
clechevallier wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: discard auth migration telemetry silently in broker mode #4299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/Runner.Listener/Runner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System;
using System;
using System.Collections.Concurrent;
using System.Collections.Generic;
using System.IO;
Expand Down Expand Up @@ -1075,6 +1075,13 @@ private async Task ReportAuthMigrationTelemetryAsync(CancellationToken token)
await _runnerServer.UpdateAgentUpdateStateAsync(runnerSettings.PoolId, runnerSettings.AgentId, "RefreshConfig", telemetry, tokenSource.Token);
}
}
catch (InvalidOperationException ex) when (ex.Message.StartsWith("SetConnection"))
{
// In broker mode (serverUrl == serverUrlV2), _runnerServer is intentionally
// not connected in BrokerMessageListener.CreateSessionAsync. Discard the
// telemetry entry silently rather than re-enqueuing it into an infinite loop.
Trace.Verbose($"Runner server not connected in broker mode, discarding auth migration telemetry: {ex.Message}");
}
catch (Exception ex)
{
Trace.Error("Failed to report auth migration telemetry.");
Expand Down