fix: discard auth migration telemetry silently in broker mode#4299
Draft
clechevallier wants to merge 1 commit intoactions:mainfrom
Draft
fix: discard auth migration telemetry silently in broker mode#4299clechevallier wants to merge 1 commit intoactions:mainfrom
clechevallier wants to merge 1 commit intoactions:mainfrom
Conversation
In broker mode (serverUrl == serverUrlV2), _runnerServer.ConnectAsync is intentionally skipped in BrokerMessageListener.CreateSessionAsync since only the broker connection is needed. However, ReportAuthMigrationTelemetryAsync still calls UpdateAgentUpdateStateAsync which calls CheckConnection(Generic), throwing InvalidOperationException: SetConnection Generic. The exception is caught, but the telemetry is re-enqueued for retry, creating a silent infinite loop that emits an ERR every ~60 seconds for the entire lifetime of every runner pod using broker mode (e.g. ARC with GitHub App auth). Fix by catching the specific InvalidOperationException from CheckConnection before the generic catch, and discarding the telemetry entry with a Trace.Verbose instead of re-enqueuing. This breaks the infinite retry loop with zero impact on non-broker runners where _runnerServer is always connected. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In broker mode (serverUrl == serverUrlV2), _runnerServer.ConnectAsync is intentionally skipped in BrokerMessageListener.CreateSessionAsync since only the broker connection is needed. However, ReportAuthMigrationTelemetryAsync still calls UpdateAgentUpdateStateAsync which calls CheckConnection(Generic), throwing InvalidOperationException: SetConnection Generic.
The exception is caught, but the telemetry is re-enqueued for retry, creating a silent infinite loop that emits an ERR every ~60 seconds for the entire lifetime of every runner pod using broker mode (e.g. ARC with GitHub App auth).
Fix by catching the specific InvalidOperationException from CheckConnection before the generic catch, and discarding the telemetry entry with a Trace.Verbose instead of re-enqueuing. This breaks the infinite retry loop with zero impact on non-broker runners where _runnerServer is always connected.