Open
Conversation
Co-authored-by: gabriel-arc <gabriel@travis-ci.org>
* repo settings merge from master
* Rspec are loading & some deprecation fixes * some Arel and handling string as hash * No more composite keys * fixing deprecations for rake - parsing json * fixing deprecations * further cleanup * Some fixex including repo - but logic must be discussed * cleanup with composite keys * Revert "cleanup with composite keys" This reverts commit c9c7960. * Revert "No more composite keys" This reverts commit 8fb395e. * further changes and fixes * More spohisticated changes * ruby, ar upgrade && annoying bug fix for composite keys * Cleanup after not proper fixes * sentry & openssl upgrade * add root to serialized json * Proper gems are used * USing old Metrics * Next fixes * almost there * All green * Further gems update * problems with simple states * removing s3 step 1 * moving s3 to fog * s3 totally removed * some Gemfile changes * docker fix * sidekiq update * better regexp * Nicely usage of Mustermann * guard for AR patch * clear active connections * nokogiri bump * Parse config if string * Ensure Hash is saved into Json settings/preferences * next approach to make settings an actual hash * Ensure settings/preferences are hash Co-authored-by: Maciej <Maciej.Kempin@coreservices.pl> Co-authored-by: gabriel-arc <gabriel@travis-ci.org>
* github_apps update * activerecord bump to 6.1.6.1 * permit symbol in yaml deserializer for debug
* BSFY-141 merge - add restarted by
* bundler update * merge from master 31.10.22 * usr/group update * ship:docker
* Add tag_name to build request * Restrict ruby gem-update version --------- Co-authored-by: piccadilly-circus <134370605+piccadilly-circus@users.noreply.github.com>
gbarc-dt
reviewed
Mar 19, 2024
Gemfile
Outdated
| gem 'travis-lock', git: 'https://github.com/travis-ci/travis-lock' | ||
| gem 'travis-github_apps', git: 'https://github.com/travis-ci/travis-github_apps' | ||
| gem 'travis-settings', git: 'https://github.com/travis-ci/travis-settings', branch: 'master' | ||
| gem 'travis-lock', git: 'https://github.com/travis-ci/travis-lock/', branch: '6.1' |
Collaborator
There was a problem hiding this comment.
master, latest updates are already merged
| gem 'travis-github_apps', git: 'https://github.com/travis-ci/travis-github_apps', branch: 'ga-ext_access' | ||
| gem 'travis-rollout', git: 'https://github.com/travis-ci/travis-rollout' | ||
| gem 'simple_states', git: 'https://github.com/travis-ci/simple_states', branch: 'prd-ruby-upgrade-dev' | ||
| gem 'metriks', git: 'https://github.com/travis-ci/metriks' |
| gem 'gh', git: 'https://github.com/travis-ci/gh' | ||
| gem 'rollout', git: 'https://github.com/travis-ci/rollout' | ||
|
|
||
| gem 'mustermann' |
Gemfile
Outdated
| gem 'pry' | ||
| gem 'http', '~> 4' | ||
| gem 'metriks', '0.9.9.6' | ||
| gem 'metriks-librato_metrics', git: 'https://github.com/eric/metriks-librato_metrics' |
Collaborator
There was a problem hiding this comment.
keep the ones from master(metriks/metriks-librato_metrics
Gemfile
Outdated
| gem "ipaddress", "~> 0.8.3" | ||
| gem 'nakayoshi_fork' | ||
| gem 'sidekiq' | ||
| gem 'sidekiq', '~> 6.4.0' |
Collaborator
There was a problem hiding this comment.
don't pin the version to 6, current is 7.x
| .to_return( | ||
| status: 200, | ||
| body: JSON.dump(keys) | ||
| body: JSON.dump( |
Collaborator
There was a problem hiding this comment.
afair its gem version related, keep master
spec/support/billing_spec_helper.rb
Outdated
| }.deep_merge(attributes) | ||
| end | ||
|
|
||
| def billing_v2_subscription_response_body(attributes={}) |
Collaborator
There was a problem hiding this comment.
if billing related and not on master - don't merge
| def initialize(key, options = {}) | ||
| def initialize(key) | ||
| @key = key | ||
| @size = options[:size] || "0" |
Collaborator
There was a problem hiding this comment.
s3 related updates on master, keep
| end | ||
|
|
||
| def add(key, options = {}) | ||
| contents << FakeObject.new(key, options) |
Collaborator
There was a problem hiding this comment.
keep master for the whole file
| end | ||
| end | ||
|
|
||
| describe '#pay_v2' do |
GbArc
requested changes
Mar 26, 2024
| end | ||
| end | ||
|
|
||
| def get_invoices_for_v2_subscription(id) |
lib/travis/api/v3/queries/jobs.rb
Outdated
| puts "USING LW JOBS!!\n\n" | ||
| jobs = V3::Models::Job.where("jobs.id in (select id from most_recent_job_ids_for_user_repositories_by_states_lw(#{user.id}, ?))", states) | ||
| else | ||
| puts "USING REGULAR JOBS!!!\n\n" |
Contributor
There was a problem hiding this comment.
pls remove these three puts - this was tcie debug
lib/travis/config/defaults.rb
Outdated
| database: { adapter: 'postgresql', database: "travis_#{Travis.env}", encoding: 'unicode', min_messages: 'warning', variables: { statement_timeout: 10_000 } }, | ||
| db: { max_statement_timeout_in_seconds: 15, slow_host_max_statement_timeout_in_seconds: 60}, | ||
| database: { adapter: 'postgresql', database: "travis_#{Travis.env}", encoding: 'unicode', min_messages: 'warning', variables: { statement_timeout: ENV['TRAVIS_DB_STATEMENT_TIMEOUT'] || 10000 } }, | ||
| db: { max_statement_timeout_in_seconds: 15, slow_host_max_statement_timeout_in_seconds: ENV['TRAVIS_MAX_DB_STATEMENT_TIMEOUT'] || 15}, |
Contributor
There was a problem hiding this comment.
change default to 60 like it was before
lib/travis/model/repository.rb
Outdated
| else | ||
| super(value.to_json) | ||
| end | ||
| value = value.is_a?(String) ? JSON.parse(value) : value |
| }.deep_merge(attributes) | ||
| end | ||
|
|
||
| def billing_addons_response_body |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.