Gateway AM-GZ80x: Update $board and meson-axg family conf

[pyavitz]

To achieve the correct DDR freq "792MHz" requested by the manufacturer, u-boot must be flashed a particular way.

• dd if=$1/u-boot.bin of=$2 conv=fsync bs=512 seek=1

As this unit is the only one currently using the meson-axg family file, I moved all the important bits into the $board.conf.

Boot tested with armbian-config and usb flash tool.

FIP: LibreELEC/amlogic-boot-fip@48afbc0
log-build-9fa72316-e73f-42c8-ad4c-8d3ef01858f1.log

AXG:BL1:d1dbf2:a4926f;FEAT:E0DC318C:2000;POC:F;EMMC:0;READ:0;0.0;CHK:0;
sdio debug board detected 
TE: 73927

BL2 Built : 16:20:36, Apr 19 2018. axg g9478cf1 - jenkins@walle02-sh

set vcck to 1100 mv
set vddee to 950 mv
Board ID = 3
CPU clk: 1200MHz
DDR low power enabled
DDR3 chl: Rank0 16bit @ 792MHz
bist_test rank: 0 2b 00 57 34 0d 5c 27 00 4f 38 10 61 00 00 00 00 00 00 00 00 00 00 00 00 601   - PASS
Rank0: 1024MB(auto)-2T-11
AddrBus test pass!
-s
Load FIP HDR from eMMC, src: 0x0000c200, des: 0x01700000, size: 0x00004000
emmc load img ok
Load BL3x from eMMC, src: 0x00010200, des: 0x01704000, size: 0x000a8000
emmc load img ok
NOTICE:  BL31: v1.3(release):6ad3c87
NOTICE:  BL31: Built : 15:53:14, Apr 19 2018
NOTICE:  BL31: AXG normal boot!
NOTICE:  BL31: BL33 decompress pass
[Image: axg_v1.1.3309-a169b16 2018-04-19 16:10:53 jenkins@walle02-sh]
OPS=0x43
25 0b 43 00 cf bc a1 97 0d ea a7 69 9d c0 36 82 
bl30:axg ver: 9 mode: 0
bl30:axg thermal0
bl30:thermal init err
[0.017938 Inits done]
secure task start!
high task start!
low task start!
ERROR:   Error initializing runtime service opteed_fast

<debug_uart>
serial_meson serial@3000: pinctrl_select_state_full: uclass_get_device_by_phandle_id: err=-19

Summary by CodeRabbit

• Refactor
  • Reorganized U-Boot configuration for the gateway-gz80x board, consolidating board-specific settings into a dedicated configuration file for improved maintainability.

[coderabbitai]

📝 Walkthrough

Walkthrough

Board-specific U-Boot configuration for the gateway-gz80x device is relocated from a family-level configuration file to a dedicated board-level configuration file, consolidating device-specific build settings and post-processing logic.

Changes

Cohort / File(s)	Summary
Board-specific U-Boot configuration config/boards/gateway-gz80x.conf	Added new configuration with post_family_config__gateway_gz80x_uboot() function declaring UBOOT_TARGET_MAP, nested functions for custom U-Boot post-processing and platform-specific write operations using dd with fsync.
Family configuration cleanup config/sources/families/meson-axg.conf	Removed gateway-gz80x-specific U-Boot configuration block, including UBOOT_TARGET_MAP variable assignment and uboot_custom_postprocess() function.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

---

🐰 A board hops free from family's nest,
Its configs tucked in dedicated best,
U-Boot maps migrate with care so fine,
Gateway-gz80x draws its own line! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: moving Gateway AM-GZ80x U-Boot configuration from meson-axg family config to board-specific config.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

config/boards/gateway-gz80x.conf (1)

25-27: Consider quoting variables and adding status=none for robustness.

The write_uboot_platform() implementation is functionally correct for achieving the manufacturer-specified DDR frequency. Two optional improvements for consistency with newer Armbian standards:

1. Quote $1 and $2 to handle paths with spaces
2. Add status=none to suppress dd's verbose output (per newer Rockchip family standard)

🔧 Optional refinement

 	write_uboot_platform() {
-		dd if=$1/u-boot.bin of=$2 conv=fsync bs=512 seek=1
+		dd if="$1/u-boot.bin" of="$2" conv=fsync bs=512 seek=1 status=none
 	}

Based on learnings: "the write_uboot_platform() function implementations follow different patterns across Rockchip family files. The newer standard (used in rockchip64_common.inc and rk3506) includes 'status=none' parameter in dd commands."

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@config/boards/gateway-gz80x.conf` around lines 25 - 27, The dd call in
write_uboot_platform() should quote the path variables and suppress dd output
for robustness: change the dd invocation in write_uboot_platform() to quote $1
and $2 (to handle spaces) and add status=none to the dd options so the command
becomes dd if="$1/u-boot.bin" of="$2" conv=fsync bs=512 seek=1 status=none.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@config/boards/gateway-gz80x.conf`:
- Around line 25-27: The dd call in write_uboot_platform() should quote the path
variables and suppress dd output for robustness: change the dd invocation in
write_uboot_platform() to quote $1 and $2 (to handle spaces) and add status=none
to the dd options so the command becomes dd if="$1/u-boot.bin" of="$2"
conv=fsync bs=512 seek=1 status=none.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: fc0e1e0f-d12d-4533-8e9e-85e813ffbe11

📥 Commits

Reviewing files that changed from the base of the PR and between a76df5f and 43f053a.

📒 Files selected for processing (2)

• config/boards/gateway-gz80x.conf
• config/sources/families/meson-axg.conf

💤 Files with no reviewable changes (1)

• config/sources/families/meson-axg.conf

[github-actions]

✅ This PR has been reviewed and approved — all set for merge!