Skip to content

meson64: a311d: Fix Xorg display when etnaviv enabled#9524

Open
retro98boy wants to merge 2 commits intoarmbian:mainfrom
retro98boy:a311d-xorg-fix
Open

meson64: a311d: Fix Xorg display when etnaviv enabled#9524
retro98boy wants to merge 2 commits intoarmbian:mainfrom
retro98boy:a311d-xorg-fix

Conversation

@retro98boy
Copy link
Contributor

@retro98boy retro98boy commented Mar 14, 2026

Description

This PR fix Xorg display when etnaviv driver enabled

How Has This Been Tested?

Build Ubuntu Noble XFCE4 system image, then tested on CAINIAO CNIoT-CORE (A311D device)

I don't have the equipment to test other devices such as the jethubj200 and odroidn2, but I think it won't break their original Xorg functionality since they all use the meson-drm driver

Summary by CodeRabbit

  • New Features

    • Extended device support to include the cainiao-cniot-core board.
  • Chores

    • Refined display configuration structure and improved formatting consistency across device settings.

@github-actions github-actions bot added 05 Milestone: Second quarter release size/small PR with less then 50 lines labels Mar 14, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1cb443e8-b76c-4c12-8eee-812bd86572ea

📥 Commits

Reviewing files that changed from the base of the PR and between 58907a3 and d601102.

📒 Files selected for processing (1)
  • config/sources/families/include/meson64_common.inc

📝 Walkthrough

Walkthrough

Configuration file updated to restructure Xorg device settings by introducing a new OutputClass block for Amlogic devices and simplifying the Screen subsection. The board recognition list was expanded by adding "cainiao-cniot-core". Minor indentation adjustments were made throughout.

Changes

Cohort / File(s) Summary
Xorg Configuration Restructuring
config/sources/families/include/meson64_common.inc
Replaced existing Screen subsection with new OutputClass block for Amlogic, followed by simplified Screen subsection containing only Depth 24 setting. Added "cainiao-cniot-core" to board list. Applied indentation consistency adjustments throughout the Device section.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A humble config file did change,
OutputClass made Amlogic arranged,
Boards grew wider with one more to see,
Cainiao-cniot now joins the spree! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'meson64: a311d: Fix Xorg display when etnaviv enabled' directly and specifically describes the main change: fixing Xorg display configuration for the a311d board when etnaviv is enabled, which matches the file modifications and PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... labels Mar 14, 2026
Copy link
Member

@EvilOlaf EvilOlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane. If it was tested, probably fine

@github-actions github-actions bot added the Ready to merge Reviewed, tested and ready for merge label Mar 14, 2026
@github-actions
Copy link
Contributor

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions bot removed the Needs review Seeking for review label Mar 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

05 Milestone: Second quarter release Hardware Hardware related like kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

3 participants