Odroid-M2: Support for weather board zero#9523
Merged
igorpecovnik merged 1 commit intoarmbian:mainfrom Mar 15, 2026
Merged
Conversation
mlegenovic
requested review from
ColorfulRhino,
HeyMeco,
JohnTheCoolingFan,
SuperKali,
TheSnowfield,
Tonymac32,
ahoneybun,
amazingfate,
brentr,
catalinii,
chainsx,
efectn,
igorpecovnik,
joekhoobyar,
krachlatte,
lanefu,
paolosabatino,
prahal,
pyavitz,
rpardini and
schwar3kat
as code owners
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughThis PR adds support for a weather board on the Odroid M2 with RK3588S by introducing new device tree overlays in both the 6.18 and 7.0 kernel branches. The overlays enable a Sensirion SHTC1 temperature/humidity sensor connected via I2C5. Corresponding Makefile entries register the new device tree binary overlays for compilation. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can approve the review once all CodeRabbit's comments are resolved.Enable the |
github-actions
bot
added
05
EvilOlaf
approved these changes
Mar 14, 2026
Contributor
|
✅ This PR has been reviewed and approved — all set for merge! |
github-actions
bot
added
size/large
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@patch/kernel/archive/rockchip64-6.18/board-odroidm2-support-for-vu8s-panel.patch`:
- Around line 426-427: The panel's viewable size fields (.width_mm and
.height_mm) are wrong for the portrait 800×1280 Vu8S panel; update them to the
rotated viewable dimensions (approx. width_mm = 108 and height_mm = 172) so
physical-size and DPI calculations are correct—locate the struct/initializer
that sets .width_mm and .height_mm in the Vu8S panel descriptor and replace the
current 135/217 values with 108/172 (integers) preserving the portrait
orientation.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 789683b2-c5c5-4d33-b636-9aa0683eba4a
📒 Files selected for processing (6)
patch/kernel/archive/rockchip64-6.18/board-odroidm2-support-for-vu8s-panel.patchpatch/kernel/archive/rockchip64-6.18/overlay/Makefilepatch/kernel/archive/rockchip64-6.18/overlay/rockchip-rk3588-odroidm2-display-vu8s.dtsopatch/kernel/archive/rockchip64-6.18/overlay/rockchip-rk3588-odroidm2-weather-board-zero.dtsopatch/kernel/archive/rockchip64-7.0/overlay/Makefilepatch/kernel/archive/rockchip64-7.0/overlay/rockchip-rk3588-odroidm2-weather-board-zero.dtso
🚧 Files skipped from review as they are similar to previous changes (3)
- patch/kernel/archive/rockchip64-7.0/overlay/Makefile
- patch/kernel/archive/rockchip64-7.0/overlay/rockchip-rk3588-odroidm2-weather-board-zero.dtso
- patch/kernel/archive/rockchip64-6.18/overlay/Makefile
patch/kernel/archive/rockchip64-6.18/board-odroidm2-support-for-vu8s-panel.patch
Outdated
Show resolved
Hide resolved
github-actions
bot
added
size/medium
Signed-off-by: Milivoje Legenovic <m.legenovic@gmail.com>
igorpecovnik
approved these changes
Mar 15, 2026
Contributor
|
✅ This PR has been reviewed and approved — all set for merge! |
github-actions
bot
added
Ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Activates the WEATHER-BOARD Zero on the 40-pin header.
Documentation summary for feature / change
This makes weather board zero usable on Odroid-M2 board with mainline kernel. To activate it
armbian-configtool to enable overlayodroidm2-weather-board-zero/boot/armbianEnv.txt(e.g.overlays=odroidm2-weather-board-zero)After reboot, verify with
sudo i2cdetect -y 5that the sensor has been detected. Then you can read values withsensorscommand (lm-sensorspackage), or by using directly HWMON subsystem (cat /sys/class/hwmon/hwmonX/{temp1_input,humidity1_input}).Checklist:
Summary by CodeRabbit