Skip to content

rockchip: Add CSC board EByte ECB41-PGE (RK3506G)#9513

Merged
igorpecovnik merged 1 commit intoarmbian:mainfrom
vidplace7:EByte-ECB41
Mar 15, 2026
Merged

rockchip: Add CSC board EByte ECB41-PGE (RK3506G)#9513
igorpecovnik merged 1 commit intoarmbian:mainfrom
vidplace7:EByte-ECB41

Conversation

@vidplace7
Copy link
Member

@vidplace7 vidplace7 commented Mar 10, 2026

Description

Adds new RK3506G CSC board EByte ECB41-PGE.
This PR also includes uboot patches (dts/defconfig) to enable this board.

Depends on:

How Has This Been Tested?

  • ./compile.sh BOARD=ebyte-ecb41-pge BRANCH=vendor KERNEL_CONFIGURE=no DEB_COMPRESS=xz KERNEL_BTF=yes INSTALL_ARMBIAN_FIRMWARE=no BUILD_DESKTOP=no BUILD_MINIMAL=yes RELEASE=trixie
  • ./compile.sh BOARD=ebyte-ecb41-pge BRANCH=vendor KERNEL_CONFIGURE=no DEB_COMPRESS=xz KERNEL_BTF=yes INSTALL_ARMBIAN_FIRMWARE=no BUILD_DESKTOP=no BUILD_MINIMAL=yes RELEASE=noble
  • Shell works over builtin USB debug interface (CH340)
  • Ethernet works

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

  • New Features
    • Added support for the EByte ECB41-PGE development board based on Rockchip RK3506G2 SoC with 128MB RAM.
    • Configured full hardware integration including dual Gigabit ethernet interfaces, SD card support, SPI-NAND flash, USB OTG, and serial communication.

@github-actions github-actions bot added size/large PR with 250 lines or more 05 Milestone: Second quarter release labels Mar 10, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 10, 2026

📝 Walkthrough

Walkthrough

This pull request introduces support for the EByte ECB41-PGE board, a Rockchip RK3506G2-based embedded system with 128MB RAM. Changes include board configuration metadata, U-Boot build flags and subsystem enablements, device tree U-Boot boot-phase properties, and complete hardware peripheral definitions across SPI flash, Ethernet, SD card, USB, UART, and power rail configurations.

Changes

Cohort / File(s) Summary
Board Configuration
config/boards/ebyte-ecb41-pge.csc
Defines board metadata constants (name, vendor, family, maintainer) and enables low-memory extension for 128MB RAM constraint.
U-Boot Build Configuration
patch/u-boot/u-boot-rk3506/defconfig/ebyte-ecb41-pge_defconfig
Configures U-Boot build flags for RK3506 architecture, enables core subsystems (DM, MTD), peripherals (Ethernet, USB, MMC, GPIO, LED), and boot parameters (console UART, FDT, load addresses).
Device Tree Definitions
patch/u-boot/u-boot-rk3506/dt/rk3506g-ebyte-ecb41-pge-u-boot.dtsi, patch/u-boot/u-boot-rk3506/dt/rk3506g-ebyte-ecb41-pge.dts
U-Boot snippet adds boot-phase markers for flash and SD card detection; full DTS provides complete hardware definitions including regulators, Gigabit MACs with RMII PHYs, SPI-NAND flash, SD card controller, USB 2.0 OTG, UART, SARADC, and comprehensive pinctrl mappings.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 A new board joins our warren today,
EByte's ECB41, ready to play!
With flash and Ethernet, USB and more,
RK3506 opens a hardware door.
From config to device trees so clear,
Our embedded dreams are drawing near! 🌟

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the main change: adding support for a new Rockchip RK3506G board (EByte ECB41-PGE). It is clear, specific, and directly reflects the changeset content.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Mar 10, 2026
@github-actions
Copy link
Contributor

🚫 Missing required board assets

This PR adds new board configuration(s). Required assets must already exist in github/armbian/armbian.github.io.
They are required by Armbian Imager to ensure all boards are displayed with proper images.

  • Board images: board-images/<board>.png (1920x1080 px transparent)
  • Vendor logos: board-vendor-logos/<vendor>-logo.png (512x512 px transparent)

Missing items

  • Board image missing for ebyte-ecb41-pge

    • Expected: board-images/ebyte-ecb41-pge.png
    • Fix: add the file to armbian/armbian.github.io (folder board-images/)
  • Vendor logo missing for vendor ebyte (used by board ebyte-ecb41-pge)

    • Expected: board-vendor-logos/ebyte-logo.png
    • Fix: add the file to armbian/armbian.github.io (folder board-vendor-logos/)
    • Naming rules: lowercase, dashes (e.g. kobol-logo.png, not Kobol_logo.png)

Once the missing files are added (or a PR is opened in armbian/armbian.github.io), re-run this check.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
patch/u-boot/u-boot-rk3506/dt/rk3506g-ebyte-ecb41-pge.dts (1)

12-17: Minor style inconsistency in aliases syntax.

The ethernet0 and ethernet1 aliases use phandle syntax with angle brackets (<&gmac0>), while mmc0 and serial0 use direct path references (&sdmmc). Both forms work, but for consistency, consider using the direct reference form throughout.

🎨 Suggested fix for consistency
 	aliases {
-		ethernet0 = <&gmac0>;
-		ethernet1 = <&gmac1>;
+		ethernet0 = &gmac0;
+		ethernet1 = &gmac1;
 		mmc0 = &sdmmc;
 		serial0 = &uart0;
 	};
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@patch/u-boot/u-boot-rk3506/dt/rk3506g-ebyte-ecb41-pge.dts` around lines 12 -
17, The aliases block mixes phandle angle-bracket syntax and direct references;
update aliases ethernet0 and ethernet1 to use the same direct-reference form as
mmc0 and serial0 by replacing <&gmac0> and <&gmac1> with &gmac0 and &gmac1
respectively so aliases (ethernet0, ethernet1, mmc0, serial0) consistently use
direct phandle references to gmac0, gmac1, sdmmc, and uart0.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@patch/u-boot/u-boot-rk3506/dt/rk3506g-ebyte-ecb41-pge.dts`:
- Around line 12-17: The aliases block mixes phandle angle-bracket syntax and
direct references; update aliases ethernet0 and ethernet1 to use the same
direct-reference form as mmc0 and serial0 by replacing <&gmac0> and <&gmac1>
with &gmac0 and &gmac1 respectively so aliases (ethernet0, ethernet1, mmc0,
serial0) consistently use direct phandle references to gmac0, gmac1, sdmmc, and
uart0.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: fffa789e-5cfc-4e20-a7d0-e467bceec802

📥 Commits

Reviewing files that changed from the base of the PR and between addbce1 and ab6cba8.

📒 Files selected for processing (4)
  • config/boards/ebyte-ecb41-pge.csc
  • patch/u-boot/u-boot-rk3506/defconfig/ebyte-ecb41-pge_defconfig
  • patch/u-boot/u-boot-rk3506/dt/rk3506g-ebyte-ecb41-pge-u-boot.dtsi
  • patch/u-boot/u-boot-rk3506/dt/rk3506g-ebyte-ecb41-pge.dts

@igorpecovnik igorpecovnik merged commit c1472ad into armbian:main Mar 15, 2026
14 checks passed
@github-actions github-actions bot added the Ready to merge Reviewed, tested and ready for merge label Mar 15, 2026
@github-actions
Copy link
Contributor

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions bot removed the Needs review Seeking for review label Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

05 Milestone: Second quarter release Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/large PR with 250 lines or more

Development

Successfully merging this pull request may close these issues.

2 participants