Report infra_error for action download failures.#4294
Open
TingluoHuang wants to merge 2 commits intomainfrom
Open
Report infra_error for action download failures.#4294TingluoHuang wants to merge 2 commits intomainfrom
TingluoHuang wants to merge 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds explicit infrastructure error reporting for action download failures so runner logs/telemetry can better distinguish download issues from other action preparation problems.
Changes:
- Introduces
FailedToDownloadActionExceptionin DTWebApi exception set. - Wraps non-cancellation download failures in
DownloadRepositoryArchivewithFailedToDownloadActionException. - Catches
FailedToDownloadActionExceptioninPrepareActionsAsyncand reports anInfrastructureErrorwith a new category.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/Sdk/DTWebApi/WebApi/Exceptions.cs |
Adds a new serializable FailedToDownloadActionException type for propagating download failures with an inner exception. |
src/Runner.Worker/ActionManager.cs |
Wraps download failures and reports them as infrastructure issues during action preparation. |
Comments suppressed due to low confidence (1)
src/Runner.Worker/ActionManager.cs:1263
DownloadRepositoryArchivenow wraps all non-cancellation exceptions inFailedToDownloadActionException. This includesActionNotFoundException(404) which previously bubbled up as a user/action configuration error (and is covered by existing L0 tests). Wrapping it will reclassify 404s as infrastructure failures (via thePrepareActionsAsynccatch) and changes the thrown exception type/behavior.
Consider excluding ActionNotFoundException (and any other intentionally-surfaced exceptions) from this wrapper, e.g. by adding a dedicated catch/rethrow before this catch, or by refining the exception filter to skip those types.
catch (Exception ex) when (!(ex is OperationCanceledException) && !executionContext.CancellationToken.IsCancellationRequested)
{
Trace.Error($"Failed to download archive '{downloadUrl}' after {retryCount + 1} attempts.");
Trace.Error(ex);
throw new FailedToDownloadActionException($"Failed to download archive '{downloadUrl}' after {retryCount + 1} attempts.", ex);
}
You can also share your feedback on Copilot code review. Take the survey.
rentziass
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure we know that download actions are failing for whatever reason, help identify and investigate server-side problem easier.