Testing improvement error shape 11054437382139627313#185
Open
Pet3cy wants to merge 9 commits intoactions:mainfrom
Open
Testing improvement error shape 11054437382139627313#185Pet3cy wants to merge 9 commits intoactions:mainfrom
Pet3cy wants to merge 9 commits intoactions:mainfrom
Conversation
- Change core.info to core.debug for model responses in src/inference.ts - Change core.info to core.debug for tool execution details in src/mcp.ts - Change core.info to core.debug for custom header logging in src/helpers.ts - Remove sensitive response previews from error messages in src/inference.ts - Update tests to reflect changes from core.info to core.debug
…re-logs-8322086360319645856 🔒 [security fix] Fix sensitive data exposure in MCP Inference logs
Updated the regex in `src/helpers.ts` to allow all valid characters in an HTTP token (RFC 7230, section 3.2.6), including symbols like `_`, `.`, `!`, and `*`. Previously, the validation was overly restrictive, only allowing alphanumeric characters and hyphens. Also updated the corresponding unit test in `__tests__/helpers.test.ts` to reflect the change.
…6518057682 🧹 Relax overly restrictive HTTP header name validation
Add test cases to verify that `parseFileTemplateVariables` correctly throws an error when a non-string value (e.g. number, boolean, object) is provided as a file path in the input YAML. This ensures the existing validation is properly tested. Co-authored-by: Pet3cy <169947521+Pet3cy@users.noreply.github.com>
…-template-variables-6142620025282989819 🧪 [testing improvement] validate non-string file paths in parseFileTemplateVariables
Added unit tests to `__tests__/inference.test.ts` to verify that `simpleInference` and `mcpInference` correctly throw an error when the OpenAI API returns a response without the expected 'choices' property. This improves the reliability and coverage of the defensive logic in `src/inference.ts`.
johan-j
approved these changes
Mar 13, 2026
johan-j
approved these changes
Mar 13, 2026
johan-j
previously approved these changes
Mar 13, 2026
johan-j
previously approved these changes
Mar 13, 2026
johan-j
previously approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.