Manually bump dependencies since it needs fixes related to the controller runtime API#4406
Open
nikola-jokic wants to merge 3 commits intomasterfrom
Open
Manually bump dependencies since it needs fixes related to the controller runtime API#4406nikola-jokic wants to merge 3 commits intomasterfrom
nikola-jokic wants to merge 3 commits intomasterfrom
Conversation
nikola-jokic
added
the
gha-runner-scale-set
Contributor
|
Hello! Thank you for your contribution. Please review our contribution guidelines to understand the project's testing and code conventions. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR manually bumps Go module dependencies (notably controller-runtime and Kubernetes libs) to pick up controller-runtime API fixes, then regenerates CRDs/manifests and updates webhook code to the newer typed admission interfaces.
Changes:
- Bump
sigs.k8s.io/controller-runtimeand relatedk8s.io/*deps; updatecontroller-gento v0.20.1. - Regenerate CRDs (both
config/and Helm chartcrds/) to match updated tooling/deps. - Update
Runner*webhooks to use typedadmission.Defaulter[T]/admission.Validator[T]and adjust webhook manifests.
Reviewed changes
Copilot reviewed 25 out of 26 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updates direct/indirect dependency versions (controller-runtime, k8s libs, etc.). |
| go.sum | Adds checksums for bumped dependency versions. |
| Makefile | Updates controller-gen install version to v0.20.1. |
| config/webhook/manifests.yaml | Reorders/updates webhook entries and adds the pod token injector webhook. |
| config/crd/bases/actions.summerwind.dev_runnersets.yaml | Regenerated CRD output (controller-gen v0.20.1). |
| config/crd/bases/actions.summerwind.dev_runners.yaml | Regenerated CRD output (controller-gen v0.20.1). |
| config/crd/bases/actions.summerwind.dev_runnerreplicasets.yaml | Regenerated CRD output (controller-gen v0.20.1). |
| config/crd/bases/actions.summerwind.dev_runnerdeployments.yaml | Regenerated CRD output (controller-gen v0.20.1). |
| config/crd/bases/actions.summerwind.dev_horizontalrunnerautoscalers.yaml | Regenerated CRD output (controller-gen v0.20.1). |
| config/crd/bases/actions.github.com_ephemeralrunnersets.yaml | Regenerated CRD output (controller-gen v0.20.1). |
| config/crd/bases/actions.github.com_ephemeralrunners.yaml | Regenerated CRD output (controller-gen v0.20.1). |
| config/crd/bases/actions.github.com_autoscalingrunnersets.yaml | Regenerated CRD output (controller-gen v0.20.1). |
| config/crd/bases/actions.github.com_autoscalinglisteners.yaml | Regenerated CRD output (controller-gen v0.20.1). |
| charts/gha-runner-scale-set-controller/crds/actions.github.com_ephemeralrunnersets.yaml | Sync chart-bundled CRDs with regenerated output. |
| charts/gha-runner-scale-set-controller/crds/actions.github.com_ephemeralrunners.yaml | Sync chart-bundled CRDs with regenerated output. |
| charts/gha-runner-scale-set-controller/crds/actions.github.com_autoscalingrunnersets.yaml | Sync chart-bundled CRDs with regenerated output. |
| charts/gha-runner-scale-set-controller/crds/actions.github.com_autoscalinglisteners.yaml | Sync chart-bundled CRDs with regenerated output. |
| charts/actions-runner-controller/crds/actions.summerwind.dev_runnersets.yaml | Sync chart-bundled CRDs with regenerated output. |
| charts/actions-runner-controller/crds/actions.summerwind.dev_runners.yaml | Sync chart-bundled CRDs with regenerated output. |
| charts/actions-runner-controller/crds/actions.summerwind.dev_runnerreplicasets.yaml | Sync chart-bundled CRDs with regenerated output. |
| charts/actions-runner-controller/crds/actions.summerwind.dev_runnerdeployments.yaml | Sync chart-bundled CRDs with regenerated output. |
| charts/actions-runner-controller/crds/actions.summerwind.dev_horizontalrunnerautoscalers.yaml | Sync chart-bundled CRDs with regenerated output. |
| apis/actions.summerwind.net/v1alpha1/zz_generated.deepcopy.go | gofmt/import alias tweak in generated deepcopy code. |
| apis/actions.summerwind.net/v1alpha1/runner_webhook.go | Migrates Runner webhook to typed admission interfaces and updated builder API. |
| apis/actions.summerwind.net/v1alpha1/runnerdeployment_webhook.go | Migrates RunnerDeployment webhook to typed admission interfaces and updated builder API. |
| apis/actions.summerwind.net/v1alpha1/runnerreplicaset_webhook.go | Migrates RunnerReplicaSet webhook to typed admission interfaces and updated builder API. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
11
to
+15
| name: webhook-service | ||
| namespace: system | ||
| path: /mutate-actions-summerwind-dev-v1alpha1-runner | ||
| failurePolicy: Fail | ||
| name: mutate.runner.actions.summerwind.dev | ||
| path: /mutate-runner-set-pod | ||
| failurePolicy: Ignore | ||
| name: mutate-runner-pod.webhook.actions.summerwind.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.