Git-2.53.0-arm64.exe can be installed on x86_64 Windows 11

[xvim64]

Existing issues matching what you're seeing

• I was not able to find an open or closed issue matching what I'm seeing

Git for Windows version

Git-2.53.0-arm64.exe can be installed on x86_64 Windows 11.
Before installation, verifying the CPU type is needed.
If it is not compatible, the installation should be aborted.

Windows version

Windows 11

Windows CPU architecture

x86_64 (64-bit)

Additional Windows version information

installation issue

Options set during installation

installation issue

Other interesting things

No response

Terminal/shell

CMD

Commands that trigger the issue

intallation issue

Expected behaviour

Before installation, verifying the CPU type is needed.
If it is not compatible, the installation should be aborted.

Actual behaviour

Git-2.53.0-arm64.exe is installed on x86_64 Windows 11.

Repository

No response

[dscho]

Feel free to imitate https://github.com/git-for-windows/build-extra/blob/3e5502444a6c350459e4a59e61aa28edc8c7a595/installer/install.iss#L1202-L1206 to implement exactly the check you desire.

[dennisameling]

Alternatively, Inno Setup has an ArchitecturesAllowed setting that can probably be used for this. I'm not sure if that has any implications compared to the existing logic that @dscho linked above. There's already some similar logic in https://github.com/git-for-windows/build-extra/blob/3e5502444a6c350459e4a59e61aa28edc8c7a595/installer/install.iss#L56-L58.

[dscho]

Alternatively, Inno Setup has an ArchitecturesAllowed setting that can probably be used for this. I'm not sure if that has any implications compared to the existing logic that @dscho linked above. There's already some similar logic in https://github.com/git-for-windows/build-extra/blob/3e5502444a6c350459e4a59e61aa28edc8c7a595/installer/install.iss#L56-L58.

Excellent finding. I'm not sure that this option existed when I was playing with the 32-bit versus 64-bit logic. I could have easily missed it back then, of course. I think that setting is a splendid idea!